Additional Terminal Unit Sizing Issues

[mjwitte]

Issue overview

Followup terminal unit sizing issue from #6338.

• In SimAirServingZones::UpdateSysSizing, DesHeatCoilInTempTU is set for heating zones only using GetHeatingSATempForSizing (similar for humrat) here. In Fix VAV min flow frac > 1.0 and a bunch of termunitsizing issues related to multiple airloops #6338, for consistency with other blocks in UpdateSysSizing, I added a loop here over cooled zones for completeness, show here. But that caused large changes in reheat coil sizing across many files - maybe these are OK, but too much to review at this point, so the new block over cooled zones was removed.

• Review diffs from system sizing refactor System sizing adjustments for Std 61.2 VRP - fix and refactor #6372 and fix here if needed.

• Review diffs from new coil sizing report New Coil Sizing Reports #6454 and possibly reinstate or modify the lines that were reverted here which, BTW, were suspected of causing diffs but nothing changed after this commit. Also, see various comments from @rraustad in New Coil Sizing Reports #6454 .
  @EnergyArchmage addressed this in 75fdccb

• Try to resolve performance hit introduced in System sizing adjustments for Std 61.2 VRP - fix and refactor #6372 Here are the timing results from System sizing adjustments for Std 61.2 VRP - fix and refactor #6372 and the prior merge which was Automatic Import of Shading from a CSV File #6388
  PR6372 timing results.pdf
  PR6388 timing results.pdf
  Addressed in add trap to not process population concurrence unless VRP present #6489

• PR6481 initially caused a bunch of new errr messages about table units conversions

  ** Warning ** Unable to find a unit conversion from Coil Entering Air Humidity Ratio at Ideal Loads Peak [kg-H2O/kg-DryAir] into IP units
+   **   ~~~   ** Applying default conversion factor of 1.0
+   ** Warning ** Unable to find a unit conversion from Outdoor Air Humidity Ratio at Ideal Loads Peak [kg-H2O/kg-DryAir] into IP units
+   **   ~~~   ** Applying default conversion factor of 1.0
+   ** Warning ** Unable to find a unit conversion from Zone Air Humidity Ratio at Ideal Loads Peak [kg-H2O/kg-DryAir] into IP units
+   **   ~~~   ** Applying default conversion factor of 1.0
+   ** Warning ** Unable to find a unit conversion from Plant Design Fluid Temperature Difference [Delta C] into IP units

These have been addressed in bb00e38 by switching to existing units strings, e.g. KGWATER/KGDRYAIR, but we might prefer to add some new units strings instead.

• Other errors from New Coil Sizing Reports #6454

5ZoneDDCycOnAny and many others
+   ** Severe  ** MyPlantSizingIndex: Could not find HOT WATER LOOP in Sizing:Plant objects.
+   **   ~~~   ** ...reference Component Type="hot water coil", Name="SPACE1-1 ZONE COIL".

UnitarySystem_WaterCoils_wMultiSpeedFan
+   ** Warning ** In calculating the design coil UA for Coil:Cooling:Water CW COOLING COIL
+   **   ~~~   ** no apparatus dew-point can be found for the initial entering and leaving conditions;
+   **   ~~~   ** the coil outlet design conditions will be changed to correct the problem.

VSHeatPumpWaterHeater
+   ** Warning ** WetBulb not converged after 101 iterations(PsyTwbFnTdbWPb)
+   **   ~~~   **  Routine=ReportCoilSelection::doFinalProcessingOfCoilData,

• Coil locations are not being found now

• Need unit tests for both Std 62 and coil sizing report.

Details

Some additional details for this issue (if relevant):

• Platform (Operating system, version)
• Version of EnergyPlus (if using an intermediate build, include SHA)
• Unmethours link or helpdesk ticket number

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Defect file added (list location of defect file here)
• Ticket added to Pivotal for defect (development team task)
• Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)

[Myoldmopar]

Closed now that #6338 and #6500 are both in.