OpenStudio will crash if you go to "Control" view in an airloop with an AirLoopHVAC Unitary System

[DavidGoldwasser]

I hit this in a old (0.11) measure test file (picture below) where we were using this for a heat pump, but was able to re-create this in a fresh model in 1.5.3. Make an empty air loop, add a unitary object to the supply side, then switch to "Control". I didn't test every unitary object, but the few I tried all crashed in this test.

Update: steps to crash are easier.

1. launch OS app
2. Make empty air loop
3. Go to Control (should crash)

So maybe it isn't about the unitary object at all, but rather not having something else like setpiont manager?

Update 2:
@kbenne I confirmed, the cause of the crash seems to be the lack of a setpoint manager. If you add a step 4, and add a mix air setpoint manager to the empty loop it no longer crashes when you go to the Control view.

[mbadams5]

It is due to this line...

OpenStudio/openstudiocore/src/openstudio_lib/HVACSystemsController.cpp

Line 1069 in e02fcf4

if( boost::optional<model::SetpointManagerSingleZoneReheat> spm = _spm->optionalCast<model::SetpointManagerSingleZoneReheat>() )

_spm is not initialized before attempting to dereference and optionally cast.