ModelObjects not translated to E+

[macumber]

Several model objects are not being translated to E+, 2ccd131. I have not done a full audit, suspect there may be others.

[DavidGoldwasser]

We can constrain this to just simulation settings for now, but we need to do a full audit that every model object is being translated.

[macumber]

The following objects do not have translate functions in the ForwardTranslator, emphasis on ones that are a problem (@kbenne @mbadams5 can you edit to include HVAC ones that are an issue?):

AirTerminalDualDuctVAV - might be problem?
AirTerminalSingleDuctConstantVolumeCooledBeam - might be problem?
BuildingStory - ok, no E+ counterpart
ClimateZones - ok, no E+ counterpart
CoilCoolingCooledBeam - might be problem?
CoilCoolingDXMultiSpeedStageData - ok, included in other translation
CoilCoolingLowTempRadiantConstFlow - likely ok, probably part of ThermalZone
CoilCoolingLowTempRadiantVarFlow - likely ok, probably part of ThermalZone
CoilCoolingDXVariableSpeedSpeedData - ok, included in other translation
CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFitSpeedData - ok, included in other translation
CoilHeatingDXMultiSpeedStageData - ok, included in other translation
CoilHeatingGasMultiStageStageData - ok, included in other translation
CoilHeatingLowTempRadiantConstFlow - likely ok, probably part of ThermalZone
CoilHeatingLowTempRadiantVarFlow - likely ok, probably part of ThermalZone
CoilHeatingDXVariableSpeedSpeedData - ok, included in other translation
CoilHeatingWaterToAirHeatPumpVariableSpeedEquationFitSpeedData - ok, included in other translation
CoilHeatingWaterBaseboard - might be problem?
ComponentCostAdjustments
ComponentData - ok, no E+ counterpart
Connection - ok, no E+ counterpart
ConnectorMixer - ok, included in other translation
ConnectorSplitter - ok, included in other translation
DefaultConstructionSet - ok, included in other translation
DefaultScheduleSet - ok, included in other translation
DefaultSubSurfaceConstructions - ok, included in other translation
DefaultSurfaceConstructions - ok, included in other translation
DesignSpecificationZoneAirDistribution
ElectricEquipmentDefinition - ok, included in other translation
ExteriorLightsDefinition - ok, included in other translation
Facility - ok, no E+ counterpart
GasEquipmentDefinition - ok, included in other translation
GenericModelObject - ok, no E+ counterpart
GlareSensor
HotWaterEquipmentDefinition - ok, included in other translation
InternalMassDefinition - ok, included in other translation
LifeCycleCostUsePriceEscalation
LightingDesignDay - ok, no E+ counterpart
LightingSimulationControl - ok, no E+ counterpart
LightingSimulationZone - ok, no E+ counterpart
LightsDefinition - ok, included in other translation
LuminaireDefinition - ok, included in other translation
ModelObjectList - ok, no E+ counterpart
OtherEquipmentDefinition - ok, included in other translation
PeopleDefinition - ok, included in other translation
ProgramControl
RadianceParameters - ok, no E+ counterpart
RefrigerationDefrostCycleParameters - ok, included in other translation
RefrigerationWalkInZoneBoundary - ok, included in other translation
RenderingColor - ok, no E+ counterpart
ScheduleRule - ok, included in other translation
StandardsInformationConstruction - ok, no E+ counterpart
StandardsInformationMaterial - ok, no E+ counterpart
SteamEquipmentDefinition - ok, included in other translation
ThermochromicGlazing
UtilityBill - ok, model objects not really implemented, should be removed
UtilityCost_Charge_Block - ok, model objects not really implemented, should be removed
UtilityCost_Charge_Simple - ok, model objects not really implemented, should be removed
UtilityCost_Computation - ok, model objects not really implemented, should be removed
UtilityCost_Qualify - ok, model objects not really implemented, should be removed
UtilityCost_Ratchet - ok, model objects not really implemented, should be removed
UtilityCost_Tariff - ok, model objects not really implemented, should be removed
UtilityCost_Variable - ok, model objects not really implemented, should be removed
WaterUseEquipmentDefinition - ok, included in other translation
WeatherFile - ok, no E+ counterpart
WeatherFileConditionType
WeatherFileDays
WindowDataFile
YearDescription - ok, no E+ counterpart
ZoneAirContaminantBalance
ZoneCapacitanceMultiplierResearchSpecial

[kbenne]

I'd say many or most of these are translated, but not registered in the objects to translate function.

[macumber]

I think we need to do better at documenting the translator, not sure if any of this stuff needs to be documented? I was also thinking we should have a case statement for each IDD object type where we explicitly say "// this object will be translated with AirLoop" or whatever

[macumber]

The ones I've highlighted are just plain being missed, you could add them to your osm in a measure and they would simply not show up in the idf

[macumber]

For the Utility objects, my feeling is we should remove them from the model. Then when we get to utility rates we can add those back in. Thoughts on that?

[kbenne]

Lets talk about this one on Monday.

[macumber]

Cool, for 1.9.0 I think I will just issue a warning for UtilityBill objects

[macumber]

@DavidGoldwasser maybe we should issue a warning for RunPeriodControlSpecialDays not being translated

https://github.com/NREL/OpenStudio/blob/develop/openstudiocore/src/energyplus/ForwardTranslator.cpp#L257

[macumber]

@kbenne what are you thoughts on all this?

[kbenne]

@macumber wanna give me a call?

[macumber]

To recap the call @kbenne and I just had:

• ForwardTranslator::translateModelObject is not particularly useful and might be deprecated
• We are in favor of registering every ModelObject with a translate function, ideally in a way that is testable
• Simulation tests should be merged with the proposed measure testing framework

[macumber]

And we are ok to merge this

[asparke2]

It appears that this issue is back based on this unmethours post from Tiejun Wu. I confirmed the issue in 1.10.0. The OS:ZoneAirContaminantBalance object shows up in the .osm, but not in the exported IDF. Also, for this particular object, the string input field is no go; should really be a dropdown.

[asparke2]

@kbenne @macumber FYI

[macumber]

Let's reopen a new issue for that