Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin and diagnostic script not catch all degenerate surfaces #598

Closed
DavidGoldwasser opened this issue Oct 30, 2013 · 4 comments
Closed

Comments

@DavidGoldwasser
Copy link
Collaborator

@macumber I'll look into this, but just thought I'd cc you. I'll run the "DisplayExtraWarnings" to find out more. I hit this on the calibration model I built from Scratch. There are no warnings when I open the model in the plugin, and when I run the new diagnostic script that specially looks for surfaces with less than 3 vertices it doesn't find any problems.

** Severe ** GetSurfaceData: There are 5 degenerate surfaces; Degenerate surfaces are those with number of sides < 3.
** ~~~ ** These surfaces should be deleted.
** ~~~ ** For explicit details on each problem surface, use Output:Diagnostics,DisplayExtraWarnings;

@macumber
Copy link
Contributor

It seems weird that E+ would handle this model differently between runs. Are you sure the same IDF caused different results?

@DavidGoldwasser
Copy link
Collaborator Author

Dan, I assume that comment is about #600 ? At any rate looks like diagnostic script just checks base and sub surafces for small surfaces and surfaces with less than 3 vertices. I should extend it for interior partition and shading. Also my small test is just are sides than 0.1 m^2. I should try to match what E+ does which is based on side less than 0.01M (thanks @rraustad).

Here is issue on this model.

** Warning ** GetSurfaceData: Very small surface area[2.21528E-004], Surface=SHADING SURFACE 71
** Warning ** GetSurfaceData: Very small surface area[2.21528E-004], Surface=Mir-SHADING SURFACE 71
** Warning ** GetSurfaceData: Very small surface area[2.21528E-004], Surface=SHADING SURFACE 74
** Warning ** GetSurfaceData: Very small surface area[2.21528E-004], Surface=Mir-SHADING SURFACE 74
** Warning ** GetSurfaceData: Very small surface area[1.73446E-004], Surface=SHADING SURFACE 78
** Warning ** GetSurfaceData: Very small surface area[1.73446E-004], Surface=Mir-SHADING SURFACE 78
** Warning ** GetSurfaceData: Very small surface area[1.73446E-004], Surface=SHADING SURFACE 88
** Warning ** GetSurfaceData: Very small surface area[1.73446E-004], Surface=Mir-SHADING SURFACE 88
** Warning ** GetSurfaceData: Very small surface area[2.76041E-004], Surface=SHADING SURFACE 81
** Warning ** GetSurfaceData: Very small surface area[2.76041E-004], Surface=Mir-SHADING SURFACE 81

@macumber macumber removed the P3 - Low label Jan 28, 2015
@macumber
Copy link
Contributor

Elizabeth Gillmor also reported that the diagnostic script does not fix errors for shading surfaces

@asparke2 FYI

@tijcolem
Copy link
Collaborator

This issue has been moved to the OpenStudio Sketchup Repository - openstudiocoalition/openstudio-sketchup-plugin#37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants