Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python Measures: Factor Ruby related source out of cli and into a shared library #4641

Closed
kbenne opened this issue Aug 2, 2022 · 0 comments · Fixed by #4674
Closed

Python Measures: Factor Ruby related source out of cli and into a shared library #4641

kbenne opened this issue Aug 2, 2022 · 0 comments · Fixed by #4674
Assignees
@kbenne
Labels
component - Measures component - Python bindings component - Ruby bindings Enhancement Request
Milestone
OpenStudio SDK 3.5.0

Comments

@kbenne
Copy link
Contributor

kbenne commented Aug 2, 2022

This is probably the highest point of risk in the introduction of Python Measures. The idea is to put the ruby related embedded files, the ruby engine, and all "the trimmings" into a shared library, therefore making the cli no longer fully self contained. Currently this content is statically linked and embedded directly into the eopnstudio command line executable program.
@kbenne kbenne self-assigned this Aug 2, 2022
kbenne added a commit that referenced this issue Aug 17, 2022
@kbenne
Refactor all things ruby into a shared library
17f0d8a 
The ruby engine is now loaded dynamically on demand like a plugin

ref #4641
kbenne added a commit that referenced this issue Aug 18, 2022
@kbenne
Add CLI11 for top level argument parsing
e6d49bf 
If the subcommand `experimental` is passed to the `openstudio` CLI, then
further argument parsing and workflow is diverted through a new C++
based pathway. If the experimental subcommand is not given then the
RubyEngine is loaded and further argument processing is handed of to the
conventional OpenStudio CLI processing and workflow.

ref #4641
@tijcolem tijcolem mentioned this issue Aug 25, 2022
Closed
20 tasks
@tijcolem tijcolem added this to the OpenStudio SDK 3.5.0 milestone Aug 26, 2022
kbenne added a commit that referenced this issue Sep 8, 2022
@kbenne
Fix linker error related to experimental cli
16cc710 
A new openstudio_utilities_minimal target is introduced for use by the
cli

ref #4641
jmarrec pushed a commit that referenced this issue Sep 13, 2022
@kbenne @jmarrec
Refactor all things ruby into a shared library
50f6c03 
The ruby engine is now loaded dynamically on demand like a plugin

ref #4641
jmarrec pushed a commit that referenced this issue Sep 13, 2022
@kbenne @jmarrec
Add CLI11 for top level argument parsing
e6d6f29 
If the subcommand `experimental` is passed to the `openstudio` CLI, then
further argument parsing and workflow is diverted through a new C++
based pathway. If the experimental subcommand is not given then the
RubyEngine is loaded and further argument processing is handed of to the
conventional OpenStudio CLI processing and workflow.

ref #4641
jmarrec pushed a commit that referenced this issue Sep 13, 2022
@kbenne @jmarrec
Fix linker error related to experimental cli
18c3b23 
A new openstudio_utilities_minimal target is introduced for use by the
cli

ref #4641
kbenne added a commit that referenced this issue Sep 14, 2022
@kbenne
Change rubyengine module extension to .dylib instead of .so
5b46fd2 
ref #4641
@jmarrec jmarrec mentioned this issue Sep 15, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kbenne kbenne

Labels
component - Measures component - Python bindings component - Ruby bindings Enhancement Request
Projects
None yet
Milestone
OpenStudio SDK 3.5.0
Development

Successfully merging a pull request may close this issue.

4641 ruby shared lib NREL/OpenStudio
3 participants
@kbenne @jmarrec @tijcolem