Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop a function to update information #112

Closed
jd-lara opened this issue Nov 2, 2018 · 7 comments
Closed

Develop a function to update information #112

jd-lara opened this issue Nov 2, 2018 · 7 comments
Assignees

Comments

@jd-lara
Copy link
Member

jd-lara commented Nov 2, 2018

No description provided.

@jd-lara jd-lara self-assigned this Nov 2, 2018
@jd-lara jd-lara changed the title Develop a function to information update. Develop a function to update information Nov 2, 2018
@claytonpbarrows
Copy link
Member

Currently the design is that a PowerSystem struct contains the timeseries information for relevant devices. This creates an issue in PowerSimulations.jl where creating problems on time selections that are not perfectly aligned with the timeseries included in the PowerSystem requires the re-instantiation of the PowerSystem object.
I believe that the correct resolution is to:

  1. Depend only on the timeseries information in the Forecast structs when creating/simulating problems in PowerSystems.jl
  2. Remove the population of timeseries fields such as scalingfactor in the PowerSystem struct and the related device structs.
  3. Provide the appropriate checks to ensure that the required timeseries information exists in a Forecast struct to enable a PowerSimulation with a PowerSystem struct.

I'll leave this open for comment, then migrate to new issues from 1, 2, and 3 as the discussion dictates.

@jd-lara
Copy link
Member Author

jd-lara commented Mar 14, 2019

I am for option 2 and then have more time series structs where we would have a device field that we can use to point to the device for which this is relevant.

@claytonpbarrows
Copy link
Member

@jd-lara is that to say that you are in support of the proposal that includes all of 1, 2, & 3? Because I think that 2 isn't strictly necessary, but would be a good idea to improve clarity.

@jd-lara
Copy link
Member Author

jd-lara commented Mar 14, 2019

@claytonpbarrows yes, implement 1 but not only for forecasts also a new struct for just time series.
Implement 2 to simplify how the data looks like and also is parsed and 3 might be needed or not.

@claytonpbarrows
Copy link
Member

@jd-lara, in some sense everything that we have enabled in PowerSimulations is optimizing schedules against a 'forecast', so until we do something different, I don't see the need for a new struct.

@jd-lara
Copy link
Member Author

jd-lara commented Mar 15, 2019

This will be resolved with the implementation of the time-series update in PowerSimulations.

@jd-lara
Copy link
Member Author

jd-lara commented Jul 15, 2019

I am closing this since now all the structs are mutable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants