Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAM_AdjustmentFactors missing variables required for PySAM #1661

Open
dguittet opened this issue Dec 12, 2023 · 0 comments
Open

SAM_AdjustmentFactors missing variables required for PySAM #1661

dguittet opened this issue Dec 12, 2023 · 0 comments

Comments

@dguittet
Copy link
Collaborator

Describe the bug
Currently the AdjustmentFactors module is manually maintained, not regenerated by export_config. This was done because adjust used to have names with ":" that conflicted with the libSAMapi interface. Adjustment factors have since been modified and new variables have been added, but SAM_AdjustmentFactors and the PySAM adjustment factors haven't been modified to follow those changes.

The automatic generation is not possible with the code as-is for the following reason. In order to use hourly, period, or timeindex adjustment factors, the enabling variable is required, such as "adjust_en_hourly". These variables are however commented out: https://github.com/NREL/ssc/blob/75b4b1778d88234149bbb693d72914c2293ee721/ssc/common.cpp#L524

So they wouldn't make it to the PySAM interface.

Expected behavior
Adjustment factors need to have all the variables required for its use.

Propose manually modifying the SAM_AdjustmentFactors and PySAM files for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants