Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailed PV and PV-Battery hourly and hourly lifetime discrepancy #1684

Closed
cpaulgilman opened this issue Jan 26, 2024 · 1 comment · Fixed by NREL/ssc#1132
Closed

Detailed PV and PV-Battery hourly and hourly lifetime discrepancy #1684

cpaulgilman opened this issue Jan 26, 2024 · 1 comment · Fixed by NREL/ssc#1132
Assignees
Labels

Comments

@cpaulgilman
Copy link
Collaborator

Describe the bug

For the Detailed PV and PV-Battery (pvsamv1) model, outputs reported as "hourly" and "hourly lifetime" have different values for some time steps. Attempting to reconcile hourly "electricity to x from y" with hourly lifetime variables like "System power generated" and "Electricity to/from grid AC" makes it unclear to users what data SAM is using for bill calculations, battery dispatch, electricity to/from grid, etc.

See attached .sam files and Excel workbook: test-hourly-vs-lifetime.zip

Tested on Windows 11 with SAM 2023.12.17 and SAM 2022.11.21.

@cpaulgilman cpaulgilman added this to the 2023 Release Patch 1 milestone Jan 26, 2024
@brtietz
Copy link
Collaborator

brtietz commented Jan 26, 2024

Electricity to/from grid for lifetime is calculated by the battery, whereas for hourly (non-lifetime) it is calculated by utility rate 5. I suspect #1676 is also the cause of this issue.

In the battery code, we have lines that round anything less than 0.002 kW to zero. If we want these to align perfectly we should add similar lines to the hourly (non-lifetime) computations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants