Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegenerator float to double check #280

Closed
sjanzou opened this issue Apr 11, 2020 · 3 comments
Closed

Codegenerator float to double check #280

sjanzou opened this issue Apr 11, 2020 · 3 comments
Assignees
Milestone

Comments

@sjanzou
Copy link
Collaborator

sjanzou commented Apr 11, 2020

c code has been fixed and lk fixed. All other languages updated but not tested - see #222
#217
https://sam.nrel.gov/forum/forum-general/2958-sam-to-matlab-code-errors-generic-system-and-battery.html
"New SDK library with GCC" user support email chain

@sjanzou sjanzou added this to the 2020 Patch 2 milestone Apr 11, 2020
@sjanzou sjanzou self-assigned this Apr 11, 2020
@cpaulgilman
Copy link
Collaborator

There have also been several questions about this issue in MATLAB on the SAM forum, for example:

https://sam.nrel.gov/forum/forum-sdk/2949

@sjanzou
Copy link
Collaborator Author

sjanzou commented May 19, 2020

Go through Matlab issues and fix mex libpointer calls for all inputs and outputs. Also, modify code generation to copy the latest sscapi.h which is included in all platforms in the application path. Fix in SAM_280 branch of SAM and update ssc cmakelists for post build events on windows. Build and test and merge into patch and develop branches

@sjanzou
Copy link
Collaborator Author

sjanzou commented May 19, 2020

For example, Matlab case for Generic-battery Residential results
image

Fix will be included in 2020.2.29 Revision 2 ssc version 240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants