Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin broken for non-English languages #103

Closed
GUI opened this issue Feb 10, 2015 · 1 comment
Closed

Admin broken for non-English languages #103

GUI opened this issue Feb 10, 2015 · 1 comment
Labels
Milestone

Comments

@GUI
Copy link
Member

GUI commented Feb 10, 2015

If your browser sends a non-English Accept-Language header that we support (Finnish, French, Italian, Russian, German, and Spanish), then the admin will completely fail to load.

This is due to us now supporting multiple languages, but we forgot to include the .js i18n files in the Rails asset precompile list, so the app is bombing with this type of error:

Sprockets::Helpers::RailsHelper::AssetPaths::AssetNotPrecompiledError: admin/locales/fi.js isn't precompiled

I think we just need to add these .js files to the precompile list. We should add better testing surrounding this into our integration tests.

@GUI GUI added the bug label Feb 10, 2015
@GUI GUI added this to the v0.7.1 milestone Feb 10, 2015
@GUI
Copy link
Member Author

GUI commented Feb 12, 2015

This has been fixed in the v0.7.1 packages that have been released. More integration tests have been added to ensure all the languages function properly in the built packages.

@GUI GUI closed this as completed Feb 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant