Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about switching the API server from Rails to lua/openresty #177

Open
GUI opened this issue Sep 24, 2015 · 4 comments
Open

Think about switching the API server from Rails to lua/openresty #177

GUI opened this issue Sep 24, 2015 · 4 comments
Labels

Comments

@GUI
Copy link
Member

GUI commented Sep 24, 2015

As part of the lua branch, the API server is currently still in Rails. However, the more I look at it, the more it seems like our stack could really be simplified and standardized further if this component also switched over to lua/openresty. Then everything would be in Lua/OpenResty, with the default admin app being a standalone ember-cli based app that's just another consumer of the REST API.

I think I'd prefer to defer this until after an initial lua release, to at least get the bulk of the lua improvements finally out there and released. But this is something that could potentially be tackled later on, or even in pieces. Basically, the aim would be to reimplement V1 of the API in a backwards compatible way, so anything consuming the API shouldn't be able to tell the difference.

@GUI GUI added the lua label Sep 24, 2015
@brylie
Copy link
Contributor

brylie commented Dec 1, 2015

To this end, are you considering a JavaScript wrapper for the REST API? E.g. an NPM package that overlays the API Umbrella REST.

@GUI
Copy link
Member Author

GUI commented Dec 2, 2015

Like a javascript SDK for the REST APIs? We don't have anything like that planned (I won't think we do much beyond JSON.parse on the responses in our own usage), but presumably you could generate an SDK library from our swagger file. It doesn't look like the swagger-codegen project currently has a generator for client-side javascript, but it looks like there might be a couple of third party options: swagger-api/swagger-codegen#78

@GUI
Copy link
Member Author

GUI commented Dec 2, 2015

And just to clarify, if we re-implement some of our underlying APIs in Lua instead of Rails, that shouldn't impact the usage of the APIs (whether you're hitting them directly or via some wrapper).

@brylie
Copy link
Contributor

brylie commented Dec 2, 2015

OK, cool. I have just written a basic Meteor wrapper. It would be nice for the wrapper to have 'official' support, as I am struggling to implement all of the endpoints. Also, a general NPM module would potentially be useful for many other integration projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants