Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Unset Restrict Access to IPs after Setting It #97

Closed
darylrobbins opened this issue Feb 3, 2015 · 4 comments
Closed

Cannot Unset Restrict Access to IPs after Setting It #97

darylrobbins opened this issue Feb 3, 2015 · 4 comments
Milestone

Comments

@darylrobbins
Copy link
Contributor

When an API user is first created in the web interface, their allowed_ips value is omitted entirely, granting them access from any IP. However, after setting a value for this field and then later clearing it, the value in mongodb is set to "allowed_ips" : [ "" ], which means they are granted access from no IP address. This is inconsistent with the default behaviour for not specifying a value for this field.

@GUI
Copy link
Member

GUI commented Feb 3, 2015

Ah, yeah, this is a bug with the allowed IPs and referrers. It's fixed in master and will be part of the v0.7 package release. Sorry for the issue!

I thought I was going to get the v0.7 packages released last week, but I'm aiming for the end of this week instead. If you don't want to wait for the fix, you can deploy master on top of your existing install, but waiting for the packages may be easier.

And just for reference, here's the details from when this issue originally got fixed.
18F/api.data.gov#155
NREL/api-umbrella-web@92f5ed7

@darylrobbins
Copy link
Contributor Author

Thanks. I did a search before raising the bug but didn't notice that one since the title was referring to the referrer. Is there a way to build a custom package from the source instead? This is one thing I haven't been able to figure out how to do yet.

@GUI GUI added this to the v0.7 milestone Feb 9, 2015
@GUI
Copy link
Member

GUI commented Feb 10, 2015

This has been released as part of the new v0.7 packages. Thank you very much for your contributions!

@GUI GUI closed this as completed Feb 10, 2015
@darylrobbins
Copy link
Contributor Author

Thanks! Looking forward to giving the new version a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants