Farm-class attribute type

[rafmudaf]

I noticed that farm.turbine_power_interps and farm.turbine_fCts are created as Numpy arrays and then converted to Python dictionaries in the only instance I found where they're used. Could these two be a dictionaries from the beginning?

## From Farm.py
    def construct_turbine_fCts(self):
        self.turbine_fCts = [(turb.turbine_type, turb.fCt_interp) for turb in self.turbine_map]

    def construct_turbine_power_interps(self):
        self.turbine_power_interps = [
            (turb.turbine_type, turb.power_interp) for turb in self.turbine_map
        ]


# From Turbine.py where power_interp comes from farm.turbine_power_interps
def power(
    ...
    # Loop over each turbine type given to get power for all turbines
    p = np.zeros(np.shape(yaw_effective_velocity))
    power_interp = dict(power_interp)             <-- HERE
    turb_types = np.unique(turbine_type_map)
    for turb_type in turb_types:
        # Using a masked array, apply the thrust coefficient for all turbines of the current
        # type to the main thrust coefficient array
        p += (
            power_interp[turb_type](yaw_effective_velocity)
            * np.array(turbine_type_map == turb_type)
        )

    return p * ref_density_cp_ct


def Ct(
    ...
    # Loop over each turbine type given to get thrust coefficient for all turbines
    thrust_coefficient = np.zeros(np.shape(average_velocities))
    fCt = dict(fCt)             <-- HERE
    turb_types = np.unique(turbine_type_map)
    for turb_type in turb_types:
        # Using a masked array, apply the thrust coefficient for all turbines of the current
        # type to the main thrust coefficient array
        thrust_coefficient += (
            fCt[turb_type](average_velocities)
            * np.array(turbine_type_map == turb_type)
        )
    thrust_coefficient = np.clip(thrust_coefficient, 0.0001, 0.9999)
    effective_thrust = thrust_coefficient * cosd(yaw_angle)
    return effective_thrust

On another note, is farm.self.turbine_fCps used?

# from Farm.py
    def construct_turbine_fCps(self):
        self.turbine_fCps = [(turb.turbine_type, turb.fCp_interp) for turb in self.turbine_map]

[rafmudaf]

@bayc @RHammond2 I don't remember the evolution of this part of the code, but I'm hoping one of you have more context.

[bayc]

@rafmudaf I think they can be created as dictionaries and not arrays. Honestly not sure why it ended up this way.

[RHammond2]

I don't think I was involved in that bit of the evolution, or at least that piece seems unfamiliar now, but I'd say a dictionary is the appropriate data structure with the way it's used currently used.