Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error checking for bar_from_space_type_ratios #115

Open
4 tasks
DavidGoldwasser opened this issue Mar 11, 2021 · 0 comments
Open
4 tasks

Improve error checking for bar_from_space_type_ratios #115

DavidGoldwasser opened this issue Mar 11, 2021 · 0 comments
Assignees

Comments

@DavidGoldwasser
Copy link
Contributor

  • There is some flexibility on spacing, but a space is required after the comma to work, make that optiona.
  • Support ratio that adds up to more than 1 by issuing warning and normalizing it
  • Support ratio that adds up to less than 1 by issuing a warning and normalizing it.
  • Support unrecognized space type names but issue warning that downstream measures like create_typical may not work as expected. I already support custom space types within a recognized building type, but not custom building types.
@DavidGoldwasser DavidGoldwasser self-assigned this Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant