Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm if use of gas is correct in CreateResults.rb #134

Open
DavidGoldwasser opened this issue Sep 24, 2021 · 0 comments
Open

Confirm if use of gas is correct in CreateResults.rb #134

DavidGoldwasser opened this issue Sep 24, 2021 · 0 comments

Comments

@DavidGoldwasser
Copy link
Contributor

# map each fuel type in EndUseFuelTypes to a specific FuelTypes
fuel_type_map = {
OpenStudio::EndUseFuelType.new('Electricity').value => OpenStudio::FuelType.new('Electricity'),
OpenStudio::EndUseFuelType.new('Gas').value => OpenStudio::FuelType.new('Gas'),
OpenStudio::EndUseFuelType.new('AdditionalFuel').value => OpenStudio::FuelType.new('Diesel'), # TODO: add other fuel types
OpenStudio::EndUseFuelType.new('DistrictCooling').value => OpenStudio::FuelType.new('DistrictCooling'),
OpenStudio::EndUseFuelType.new('DistrictHeating').value => OpenStudio::FuelType.new('DistrictHeating'),
OpenStudio::EndUseFuelType.new('Water').value => OpenStudio::FuelType.new('Water')
}
# map each fuel type in EndUseFuelTypes to a specific FuelTypes
fuel_type_alias_map = {
OpenStudio::EndUseFuelType.new('Electricity').value => 'electricity',
OpenStudio::EndUseFuelType.new('Gas').value => 'gas',
OpenStudio::EndUseFuelType.new('AdditionalFuel').value => 'other_energy',
OpenStudio::EndUseFuelType.new('DistrictCooling').value => 'district_cooling',
OpenStudio::EndUseFuelType.new('DistrictHeating').value => 'district_heating',
OpenStudio::EndUseFuelType.new('Water').value => 'water'
}

This method is only used by Utility specific and generic QAQC measure. (may be commented out and not used in generic). Confirm if use of gas instead of natural gas is correct and also see if fule_type_map is still needed as it isn't referred to tin this file, but maybe is from the measures?

@asparke2 any thoughts on this. My test in generic just looks at HTML file that may not exercise or look at results for these methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant