Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS 3.4 issue with space type wizard for some building types #149

Open
DavidGoldwasser opened this issue Jul 11, 2022 · 1 comment
Open
Assignees

Comments

@DavidGoldwasser
Copy link
Contributor

See issue in model articulation repo
NREL/openstudio-model-articulation-gem#104

@DavidGoldwasser DavidGoldwasser self-assigned this Jul 11, 2022
@DavidGoldwasser
Copy link
Contributor Author

DavidGoldwasser commented Jul 18, 2022

In making test for this in extension gem, I found an unrelated failure when using an empty model and 2004 as template where I get divided by zero error.

This doesn't happen with 2007 or 2013

` Failure/Error: bldg_def_const_set = standard.model_add_construction_set(model, climate_zone, lookup_building_type, nil, is_residential)

 ZeroDivisionError:
   divided by 0
 # ./.bundle/install/ruby/2.7.0/gems/openstudio-standards-0.2.16/lib/openstudio-standards/prototypes/common/objects/Prototype.Model.rb:2725:in `/'
 # ./.bundle/install/ruby/2.7.0/gems/openstudio-standards-0.2.16/lib/openstudio-standards/prototypes/common/objects/Prototype.Model.rb:2725:in `model_get_window_area_info'
 # ./.bundle/install/ruby/2.7.0/gems/openstudio-standards-0.2.16/lib/openstudio-standards/standards/ashrae_90_1/ashrae_90_1_2004/ashrae_90_1_2004.Model.rb:17:in `model_get_percent_of_surface_range'
 # ./.bundle/install/ruby/2.7.0/gems/openstudio-standards-0.2.16/lib/openstudio-standards/standards/Standards.Model.rb:2527:in `model_find_and_add_construction'
 # ./.bundle/install/ruby/2.7.0/gems/openstudio-standards-0.2.16/lib/openstudio-standards/standards/Standards.Model.rb:2708:in `model_add_construction_set'
 # ./lib/openstudio/extension/core/os_lib_model_generation.rb:3489:in `wizard'
 # ./spec/openstudio/core/os_lib_model_generation_spec.rb:1262:in `run'
 # ./spec/openstudio/core/os_lib_model_generation_spec.rb:1274:in `block (3 levels) in <top (required)>'`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

1 participant