Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueError in battery sizing functions causes errors for batch jobs #134

Open
brtietz opened this issue Jan 23, 2023 · 1 comment
Open
Assignees

Comments

@brtietz
Copy link
Collaborator

brtietz commented Jan 23, 2023

The dGen team reported that they were commenting out the following lines in their local PySAM implementations in order to make their code run successfully:

raise ValueError("Could not meet desired battery capacity. Consider adjusting the desired voltage, "

While that line makes sense for a single resizing, we should consider the implications for batch jobs. Decide whether to:

  1. Maintain the error as is, but add try-except to our examples (with recommendations of how to handle the except_
  2. Increase the tolerance
  3. Provide a user-specified tolerance or allow users to turn the error off in the function call.
@brtietz
Copy link
Collaborator Author

brtietz commented Feb 20, 2023

I tried (1) today and it didn't have the hoped for results in dGen - code outside of the relevant function needs to access battery output variables, so it would end up being a larger refactor. I'm leaning (3) and putting this on the SAM meeting agenda to discuss.

@brtietz brtietz self-assigned this Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant