Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improper clearsky interval labeling #243

Open
mdeceglie opened this issue Nov 20, 2020 · 1 comment
Open

Improper clearsky interval labeling #243

mdeceglie opened this issue Nov 20, 2020 · 1 comment
Assignees
@mdeceglie @kandersolar
Projects
Version 2.1

Comments

@mdeceglie
Copy link
Collaborator

Describe the bug
Clear sky irradiance and sun position are calculated instantaneously but treated as right-labeled averages in the example notebooks and TrendAnalysis of #117

Expected behavior
The most robust behavior would be to calculate at high frequency and aggregate.
@wholmgren
Copy link

Relevant thread on the pvlib python Google group: https://groups.google.com/d/msgid/pvlib-python/94230269-3421-4d50-a49c-79e46c3c815fn%40googlegroups.com

@mdeceglie mdeceglie self-assigned this Mar 5, 2021
@cdeline cdeline added this to To do in Version 2.1 May 3, 2021
@kandersolar kandersolar mentioned this issue Jun 17, 2021
Merged
2 tasks
@cdeline cdeline moved this from To do to Ready for review in Version 2.1 Jun 28, 2021
@kandersolar kandersolar moved this from Ready for review to Done in Version 2.1 Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdeceglie mdeceglie

@kandersolar kandersolar

Labels
None yet
Projects
Version 2.1
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wholmgren @mdeceglie @kandersolar