Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit test runner #49

Closed
abshinn opened this issue Nov 1, 2017 · 5 comments · Fixed by #100
Closed

Improve unit test runner #49

abshinn opened this issue Nov 1, 2017 · 5 comments · Fixed by #100

Comments

@abshinn
Copy link
Collaborator

abshinn commented Nov 1, 2017

Make use of unittests' TestSuite class for running unit tests. This will make it easier to measure test coverage.

@abshinn abshinn self-assigned this Nov 1, 2017
@mikofski
Copy link
Contributor

I recommend using pytest to autodiscover all of your tests, even Python unittest.TestCase. Then you can remove the install: pip install . and just have install pip install -r $REQ_FILE in .travis.yml and you can remove run_test as well. Also consider maybe moving your tests folder into the rdtools package, and making rdtools.tests a package. See my post on recommended project layout - note, there are many styles, and your current layout is fine.

@abshinn
Copy link
Collaborator Author

abshinn commented Aug 20, 2018

Fixed in PR #81.

@abshinn abshinn closed this as completed Aug 20, 2018
@mdeceglie
Copy link
Collaborator

I suggest keeping issues open until they are fixed in a release. One they are fixed in the development branch we can add the label "Fixed in development branch" until they are incorporated in a new release.

@mdeceglie mdeceglie reopened this Aug 20, 2018
@mikofski
Copy link
Contributor

mikofski commented Aug 20, 2018

If you put the words "fixes/closes #issue" in the commit message or in the PR main comment then when the commit/PR is merged to master (or the default branch), the issue will close automatically.

See https://help.github.com/articles/closing-issues-using-keywords/

When a pull request or commit references a keyword and issue number, it creates an association between the pull request and the issue. When the pull request is merged into your repository's default branch
, the corresponding issue is automatically closed.

@abshinn
Copy link
Collaborator Author

abshinn commented Aug 21, 2018

@mdeceglie Ah, makes sense. If people run into a problem in master, they can see whether or not it has already been fixed in development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants