Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify API for accessing databroker and provide implementation for other beamlines #10

Closed
leofang opened this issue Jan 15, 2019 · 5 comments
Milestone

Comments

@leofang
Copy link
Collaborator

leofang commented Jan 15, 2019

Currently the GUI is tied to @NSLS-II-HXN, but other beamlines (such as @NSLS-II-CSX) may also want to use it. We should define some API for flexible coupling to beamline-specific databroker processing functions.

Part of the work will involve creating a switch of some kind to select beamline profiles. Also, defer imports of beamline-specific packages to the corresponding databroker wrappers (e.g., don't import hxntools when the main window starts).

@leofang
Copy link
Collaborator Author

leofang commented Jan 25, 2019

See NSLS-II/PyXRF/pull/138 for how PyXRF does this.

@leofang
Copy link
Collaborator Author

leofang commented Mar 29, 2019

I'm following up this thread (slowly!) @wen-hu, is this something that still interests you? For now I'm thinking to have a file called nsls2ptycho/core/CSX_databroker.py as a drop-in replacement so that we can switch to it in the GUI. If possible, can you show me how the following two code segments can be replaced for their equivalences at CSX?

https://github.com/leofang/ptycho_gui/blob/6803eadd911acb9e6031c493c93b5a3f998005b2/nsls2ptycho/core/HXN_databroker.py#L11-L18

https://github.com/leofang/ptycho_gui/blob/6803eadd911acb9e6031c493c93b5a3f998005b2/nsls2ptycho/core/HXN_databroker.py#L41-L100

I remember you showed me a Jupyter notebook long ago but I can't find it now. Plus you may have changed the practice in your recent experiments, so it'd also be nice for me to be updated.

Thanks!

@leofang
Copy link
Collaborator Author

leofang commented Jun 25, 2019

It seems @NSLS-II-CHX also does some ptychography work? See NSLS-II-CHX/pyCHX.

@leofang
Copy link
Collaborator Author

leofang commented Oct 17, 2019

The majority of this issue is resolved in #65. Closing this.

@leofang
Copy link
Collaborator Author

leofang commented Oct 17, 2019

It seems @NSLS-II-CHX also does some ptychography work? See NSLS-II-CHX/pyCHX.

This is tracked in #67.

@leofang leofang added this to the v1.4.0 milestone Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant