Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

cwnd can now be less than 2 #7

Closed
larseggert opened this issue Nov 16, 2020 · 2 comments · Fixed by #9
Closed

cwnd can now be less than 2 #7

larseggert opened this issue Nov 16, 2020 · 2 comments · Fixed by #9
Assignees
Labels
design Normative change relative to RFC8312 or earlier bis versions

Comments

@larseggert
Copy link
Contributor

@martinthomson raised this on the QUIC slack:

      W_max = cwnd;                 // save window size before reduction
      ssthresh = cwnd * beta_cubic; // new slow-start threshold
      ssthresh = max(ssthresh, 2);  // threshold is at least 2 MSS
      cwnd = cwnd * beta_cubic;     // window reduction

cwnd can now be less than 2.

@goelvidhi
Copy link
Contributor

Ah.. for this code, a simple fix would be:

W_max = cwnd;                 // save window size before reduction
      ssthresh = cwnd * beta_cubic; // new slow-start threshold
      ssthresh = max(ssthresh, 2);  // threshold is at least 2 MSS
      cwnd = ssthresh;                    // window reduction

I can work on this one, if no one else is.

@sangtaeha
Copy link
Contributor

Yes, Linux also implements it this way.

@larseggert larseggert added the design Normative change relative to RFC8312 or earlier bis versions label Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design Normative change relative to RFC8312 or earlier bis versions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants