Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why the build model part of these two files (P_cause.py and P_emotion.py) is the same, it should be different from the paper. #11

Open
guo-huojian opened this issue May 1, 2020 · 1 comment

Comments

@guo-huojian
Copy link

No description provided.

@bbruceyuan
Copy link

General Response

hi, they are actually different. The reason is that the source code is not very readable of the build_model part. The order of return values of function build_model is different in P_emotion.py and P_cause.py. In P_emotion.py, it's return pred_pos, pred_cause, reg. And in P_cause.py, it's return pred_cause, pred_pos, reg. As a result, model implementation is the same with paper. It's just an issue about the naming problem. If you want to find a readable version of ECPE implementation, my PyTorch implementation might be helpful, and the link is https://github.com/bbruceyuan/ECPE-PyTorch.

Detail explanation

the scope name in P_emotion.py and P_cause.py are different.

u will find in P_cause.py, the author predict cause first and concatenates predict cause logits with clause representation to predict emotion.

While in P_emotion.py, the author predicts emotion first and concatenates predict emotion logits with clause representation to predict cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants