Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a roundtrip unit test for coordinate utilities #978

Open
Bidski opened this issue Nov 11, 2022 · 0 comments
Open

Make a roundtrip unit test for coordinate utilities #978

Bidski opened this issue Nov 11, 2022 · 0 comments
Labels
-Enhancement Enhancement of existing features D-Good-First-Issue Difficult Level: Good first issue L-C++ Uses or involves C++

Comments

@Bidski
Copy link
Contributor

Bidski commented Nov 11, 2022

Should add an extra unit test that randomly generates cartesian coordinates then tries to round trip them (cart -> spherical -> cart -> spherical) and then check that the two carts are equal and the two spherical are equal. This will let us know that the functions are inverses of each other
@Bidski Bidski added -Enhancement Enhancement of existing features D-Good-First-Issue Difficult Level: Good first issue L-C++ Uses or involves C++ labels Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-Enhancement Enhancement of existing features D-Good-First-Issue Difficult Level: Good first issue L-C++ Uses or involves C++
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bidski