Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] make_feature_column_workflow doesn't work with categorical columns #763

Closed
benfred opened this issue Apr 22, 2021 · 0 comments · Fixed by #935
Closed

[BUG] make_feature_column_workflow doesn't work with categorical columns #763

benfred opened this issue Apr 22, 2021 · 0 comments · Fixed by #935
Assignees
Labels
bug Something isn't working P1
Projects

Comments

@benfred
Copy link
Member

benfred commented Apr 22, 2021

Since the API overhaul in 0.4 - the make_feature_column_workflow function doesn't work with categorical data.

The problem is that its trying to directly set the category statistics on the workflow https://github.com/NVIDIA/NVTabular/blob/8b834310680154c102237b14cd36c165aa5c4cff/nvtabular/framework_utils/tensorflow/feature_column_utils.py#L292-L301

We should update to using a fit categorify op - and add a test to catch this in the future

@benfred benfred added the bug Something isn't working label Apr 22, 2021
@benfred benfred added this to To do in v0.6 via automation May 10, 2021
@viswa-nvidia viswa-nvidia added this to the NVTabular v0.6 milestone Jun 2, 2021
@benfred benfred moved this from To do to P1 in v0.6 Jun 26, 2021
@benfred benfred added the P1 label Jun 26, 2021
@marcromeyn marcromeyn moved this from P1 to In progress in v0.6 Jul 12, 2021
v0.6 automation moved this from In progress to Done Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1
Projects
No open projects
v0.6
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants