Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XGBoost Integration #132

Closed
viswa-nvidia opened this issue Jan 14, 2022 · 2 comments · Fixed by #433, #462, #466 or #522
Closed

XGBoost Integration #132

viswa-nvidia opened this issue Jan 14, 2022 · 2 comments · Fixed by #433, #462, #466 or #522
Assignees
@oliverholworthy
Labels
enhancement New feature or request
Milestone
Merlin 22.07

Comments

@viswa-nvidia
Copy link

https://docs.google.com/presentation/d/1jxj9zjeRRu1BJSf8tzaWoQVr5h7HZbOUsSh39Rcwv80/edit#slide=id.g10be2c57ddf\_7\_2

Aha! Link: https://nvaiinfa.aha.io/features/MERLIN-673
@benfred benfred changed the title Model Library - Collaborative Filtering - XGBoost XGBoost Integration Jan 26, 2022
@oliverholworthy oliverholworthy mentioned this issue May 12, 2022
Merged
5 tasks
@benfred benfred added enhancement New feature or request and removed RMP P0 labels May 12, 2022
@benfred benfred mentioned this issue May 12, 2022
Closed
4 tasks
@benfred benfred assigned oliverholworthy and unassigned benfred May 12, 2022
This was linked to pull requests Jun 15, 2022
First sketch of XGBoost integration with Merlin Dataset #433
Merged
XGBoost - Change group_columns to qid_column #462
Merged
XGBoost - Switch to dask API #466
Merged
@viswa-nvidia viswa-nvidia added this to the Merlin 22.07 milestone Jun 22, 2022
@radekosmulski radekosmulski mentioned this issue Jun 22, 2022
Merged
@radekosmulski
Copy link
Contributor

Hey! I am not sure if this is the right place to post this, @bschifferer asked me to work on an example for the xgboost integration and I left some thoughts in a PR #522. Not sure on the process side of things, where things should go or if what I share there can be helpful, if I am doing something wrong or these thoughts are not adding value, please let me know 🙂Thank you!

@radekosmulski
Copy link
Contributor

I am not sure if I should have linked my PR here in the first place, but the three of us (@bschifferer, @oliverholworthy, and me) just had a great chat, I also now know what would be the way to capture all this feedback (via feature requests in Merlin Models), so essentially all is well 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverholworthy oliverholworthy

Labels
enhancement New feature or request
Projects
None yet
Milestone
Merlin 22.07
4 participants
@benfred @oliverholworthy @radekosmulski @viswa-nvidia