Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upload_pdf_files does not check for file type or format #12

Closed
OlegSudakov opened this issue Dec 5, 2023 · 1 comment
Closed

upload_pdf_files does not check for file type or format #12

OlegSudakov opened this issue Dec 5, 2023 · 1 comment
Assignees
@shubhadeepd
Labels
bug Something isn't working

Comments

@OlegSudakov
Copy link

Experimenting with notebooks can create .ipynb_checkpoints folder in RetrievalAugmentedGeneration/notebooks/dataset.
image

This will cause upload_pdf_files function to fail when increasing NUM_DOCS_TO_UPLOAD. The issue does not occur with default NUM_DOCS_TO_UPLOAD (100), as the number of .pdf files in dataset.zip is greater than 100.

image
@shubhadeepd shubhadeepd self-assigned this Dec 13, 2023
@shubhadeepd shubhadeepd added the bug Something isn't working label Dec 13, 2023
@shubhadeepd
Copy link
Collaborator

@OlegSudakov Thanks for pointing this bug out.
This should have been fixed with the latest v0.2.0 release.
https://github.com/NVIDIA/GenerativeAIExamples/blob/main/notebooks/05_dataloader.ipynb
Feel free to close this issue after checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shubhadeepd shubhadeepd

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OlegSudakov @shubhadeepd