Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed training all-reduce order #107

Open
zhiqi-0 opened this issue May 31, 2021 · 5 comments
Open

Distributed training all-reduce order #107

zhiqi-0 opened this issue May 31, 2021 · 5 comments
Labels
stale No activity in 60 days on issue or PR

Comments

@zhiqi-0
Copy link

zhiqi-0 commented May 31, 2021

Hi,

I'm just wondering if there is a potential issue for all-reduce order when both data parallelism and tensor model parallelism are enabled during training. With torch DDP, both tensor model parallelism and data parallelism use all-reduce, and are launched on different streams. While the execution order is determined by hardware, will it cause hanging in some cases like:

GPU1: [MP] all-reduce -> [DP] all-reduce
GPU2: [DP] all-reduce -> [MP] all-reduce

From issues discussed here, I think it may be unsafe for undetermined order.

@github-actions
Copy link

Marking as stale. No activity in 60 days. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale No activity in 60 days on issue or PR label Jul 10, 2023
@jon-barker jon-barker reopened this Jul 20, 2023
@github-actions github-actions bot removed the stale No activity in 60 days on issue or PR label Jul 21, 2023
@github-actions
Copy link

Marking as stale. No activity in 60 days.

@github-actions github-actions bot added the stale No activity in 60 days on issue or PR label Sep 19, 2023
@fwyc0573
Copy link

fwyc0573 commented Jan 8, 2024

I have encountered the same problem. Can anyone provide some opinions?

@deepakn94
Copy link
Collaborator

@fwyc0573 are you seeing a hang? Can you describe the setting, perhaps provide an example command line, and also paste the last couple of lines in the logs?

@github-actions github-actions bot removed the stale No activity in 60 days on issue or PR label Jan 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

Marking as stale. No activity in 60 days.

@github-actions github-actions bot added the stale No activity in 60 days on issue or PR label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale No activity in 60 days on issue or PR
Projects
None yet
Development

No branches or pull requests

4 participants