Add TensorFlow client api example #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuanTingHsieh
force-pushed
the
add_tf_client_api_example
branch
from
43780ee
to
07bbaab
Compare
|
/build |
YuanTingHsieh
requested review from
chesterxgchen,
holgerroth,
SYangster,
nvkevlu and
ZiyueXu77
examples/hello-world/ml-to-fl/jobs/client_api/app/config/config_exchange.conf
Outdated
Show resolved
Hide resolved
examples/hello-world/ml-to-fl/jobs/tensorflow/app/custom/tf_model_persistor.py
Outdated
Show resolved
Hide resolved
examples/hello-world/ml-to-fl/jobs/tensorflow/app/custom/tf_utils.py
Outdated
Show resolved
Hide resolved
YuanTingHsieh
force-pushed
the
add_tf_client_api_example
branch
from
33849e3
to
4f86ca9
Compare
examples/hello-world/ml-to-fl/pt/job_templates/client_api/config_exchange.conf
Outdated
Show resolved
Hide resolved
examples/hello-world/ml-to-fl/pt/job_templates/client_api/config_exchange.conf
Outdated
Show resolved
Hide resolved
examples/hello-world/ml-to-fl/pt/job_templates/client_api/config_exchange.conf
Outdated
Show resolved
Hide resolved
examples/hello-world/ml-to-fl/pt/job_templates/client_api/config_exchange.conf
Outdated
Show resolved
Hide resolved
examples/hello-world/ml-to-fl/pt/job_templates/client_api/config_exchange.conf
Outdated
Show resolved
Hide resolved
examples/hello-world/ml-to-fl/pt/job_templates/client_api/info.conf
Outdated
Show resolved
Hide resolved
examples/hello-world/ml-to-fl/pt/job_templates/client_api/info.md
Outdated
Show resolved
Hide resolved
examples/hello-world/ml-to-fl/pt/job_templates/decorator/config_exchange.conf
Outdated
Show resolved
Hide resolved
YuanTingHsieh
force-pushed
the
add_tf_client_api_example
branch
from
9c8b10f
to
b880e43
Compare
There was a problem hiding this comment.
In general looks Good.
please double check the followings before merge
- since you removed the config_exchange.conf, can you make sure the job CLI still works ?
- The job CLI tutorial shows the config_exchange.conf, can you check the notebooks and remove the config_exchange related command
- step and step examples notebooks also has markup and notes referring config_exchange.conf please correct them as needed.
- fix the 3.9 unit test failure
YuanTingHsieh
force-pushed
the
add_tf_client_api_example
branch
from
b880e43
to
672df0b
Compare
|
/build |
|
Jenkins not working because of changes in #1984 Yan is working on a fix for that, we can ignore the blossom-ci tests for now. |
6 tasks
holgerroth
pushed a commit
to holgerroth/NVFlare
that referenced
this pull request
Dec 4, 2023
* Rename script names to avoid confusion * delete sag_lightning job templates * Add more comments to job configurations * Rename folder codes to pt * Return model copy but not the cache model directly * Fix paths in step-by-step * Add TensorFlow example * Fix meta and link * Use job_templates to avoid duplicate codes * Change wording * Fix link * Use tensorflow save_weights/load_weights method * Fix wording * Use two job_templates * Combine config_exchange and config_fed_client * Address comments * Remove config exchange and fix unit test * Remove invalid test entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
./runtest.sh.