Fobs auto register #2567
Merged
Fobs auto register #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do we need to do this now? If not functionally required, we should wait until after 2.5.0. |
|
This is functional required. Without this, user can not define their custom class or define a custom class they have to learn how to build a decomposed component and learn how to register three components in client , server and agent
…________________________________
From: Yan Cheng ***@***.***>
Sent: Wednesday, May 8, 2024 2:42 PM
To: NVIDIA/NVFlare ***@***.***>
Cc: Chester Chen ***@***.***>; Review requested ***@***.***>
Subject: Re: [NVIDIA/NVFlare] Fobs auto register (PR #2567)
Why do we need to do this now? If not functionally required, we should wait until after 2.5.0.
—
Reply to this email directly, view it on GitHub<#2567 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAD5FQ3FAIJPB3JXMNBYQ7DZBKL3LAVCNFSM6AAAAABHNGVB6SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBRGUZDQNRUGQ>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
…ers folder, and user defined decomposer_module.
|
Added unit test. |
yanchengnv
requested changes
May 10, 2024
|
Removed the custom decomposers register for SP and CP. |
|
/build |
1 similar comment
|
/build |
nvidianz
pushed a commit
to nvidianz/NVFlare
that referenced
this pull request
May 22, 2024
* WIP: auto register fobs. * WIP * Made changes to server and client fobs_initialize(). * Added auto fobs regiater. * codestyle fix. * Adjust to use register_nvflare_decomposers() for IPCAgent. * add some cleanup. * codestyle fix. * Codestyle fix. * re-design the custom Fobs register to only scan from nvflare_decomposers folder, and user defined decomposer_module. * removed no use import. * Added unit test for custom_fobs_initialize(). * Addressed the PR reviews. * changed a log warning message. * Added None handling for register_ext_decomposers. * Fixed unit test. * fixed unit test. * fix unit test. * codestyle fix. * Removed the custom decomposer regoister for SP and CP. Added the register for simulator_worker. * removed no use import. --------- Co-authored-by: Yuan-Ting Hsieh (謝沅廷) <yuantingh@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
Add the ability to automatically register all the Fobs decomposers.
Types of changes
./runtest.sh.