Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] TargetEncoding doesn't work on CPU only systems #976

Closed
benfred opened this issue Jul 20, 2021 · 1 comment · Fixed by #1039
Closed

[BUG] TargetEncoding doesn't work on CPU only systems #976

benfred opened this issue Jul 20, 2021 · 1 comment · Fixed by #1039
Assignees
@albert17
Labels
bug Something isn't working cpu P1
Projects
v0.7 (21.09)
Milestone
NVTabular-v21.09

Comments

@benfred
Copy link
Member

benfred commented Jul 20, 2021 •
edited

Running the TargetEncoding operator doesn't work on systems without cudf installed.
@benfred benfred added bug Something isn't working cpu labels Jul 20, 2021
@benfred benfred added the P1 label Aug 6, 2021
@benfred benfred added this to P1 in v0.7 (21.09) Aug 13, 2021
@albert17
Copy link
Contributor

Unit tests will not catch this error, since it is not running when no GPU: https://github.com/NVIDIA/NVTabular/blob/main/tests/unit/test_ops.py#L68

@albert17 albert17 linked a pull request Aug 17, 2021 that will close this issue
Fixes Target Encode for CPU #1039
Merged
@albert17 albert17 moved this from P1 to In Progress in v0.7 (21.09) Aug 17, 2021
@viswa-nvidia viswa-nvidia added this to the NVTabular-v21.09 milestone Aug 31, 2021
v0.7 (21.09) automation moved this from In Progress to Done Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albert17 albert17

Labels
bug Something isn't working cpu P1
Projects
No open projects
v0.7 (21.09)
  
Done
Milestone
NVTabular-v21.09
Development

Successfully merging a pull request may close this issue.

Fixes Target Encode for CPU
3 participants
@benfred @albert17 @viswa-nvidia