feat: Try to submit review before exit

Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
pytorch · Apr 21, 2021 · 9a9d7f0 · 9a9d7f0
1 parent f70bed6
commit 9a9d7f0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/.github/scripts/run_cpp_linter.py b/.github/scripts/run_cpp_linter.py
@@ -23,8 +23,10 @@
 if output.returncode != 0:
     comment = '''There are some changes that do not conform to C++ style guidelines:\n ```diff\n{}```'''.format(output.stdout.decode("utf-8"))
     approval = 'REQUEST_CHANGES'
-    exit(1)
 
 pr.create_review(commit, comment, approval)
 
-
+if output.returncode != 0:
+    exit(1)
+else:
+    exit(0)
diff --git a/.github/scripts/run_py_linter.py b/.github/scripts/run_py_linter.py
@@ -23,6 +23,10 @@
 if output.returncode != 0:
     comment = '''There are some changes that do not conform to Python style guidelines:\n ```diff\n{}```'''.format(output.stdout.decode("utf-8"))
     approval = 'REQUEST_CHANGES'
-    exit(1)
 
 pr.create_review(commit, comment, approval)
+
+if output.returncode != 0:
+    exit(1)
+else:
+    exit(0)