Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a supportable graph API #26

Closed
narendasan opened this issue Mar 23, 2020 · 0 comments
Closed

Create a supportable graph API #26

narendasan opened this issue Mar 23, 2020 · 0 comments
Labels
component: core Issues re: The core compiler feature request New feature or request good first issue Good for newcomers

Comments

@narendasan
Copy link
Collaborator

Right now as if a graph is not supported, it will still run through the converters until it hits an unsupported op. We should have a light weight way to determine support and what ops need to be implemented to support the graph.
@narendasan narendasan added feature request New feature or request good first issue Good for newcomers component: core Issues re: The core compiler labels Mar 23, 2020
narendasan added a commit to narendasan/TRTorch that referenced this issue Mar 24, 2020
@narendasan
feat(CheckMethodOperatorSupport): A new API which will check the graph
28ee445 
to see if all operators are supported. Addresses pytorch#26.

Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>
@narendasan narendasan mentioned this issue Mar 24, 2020
Merged
frank-wei pushed a commit that referenced this issue Jun 4, 2022
Back out "Add baddbmm operator support" (#26)
8f1233e 
Summary:
Pull Request resolved: https://github.com/pytorch/fx2trt/pull/26

Original commit changeset: efd417b2b494

Original Phabricator Diff: D34743279 (https://github.com/pytorch/fx2trt/commit/4f75c6f42213c841880de5358d32a9cee09beb4f)

Reviewed By: frank-wei

Differential Revision: D35002287

fbshipit-source-id: 7929aae49ef1daa0e116ba930f25a40c9b1388aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: core Issues re: The core compiler feature request New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@narendasan