-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with CMake when cuDecomp is used a subdirectory #25
Comments
Hi @ASKabalan, thanks for reporting the issue and the suggestion. I've added this in #26 if you want to give it a try. Let me know if it works for your use case and I will merge the change. By the way, I see this is part of a big PR to update jaxDecomp (DifferentiableUniverseInitiative/jaxDecomp#7). I am planning to cut a new release of cuDecomp soon so do let me know if there are any other changes that you'd like to be included before I make the release. |
Everything is great on our end, I have some debugging to do but the PR should be ready to merge. |
Good to hear the change works for you! I'd prefer not to update the C++ standard for cuDecomp unless there is change to this codebase that requires it. |
Yes it makes sense, Thank you. |
First of all, thank you very much for adding a CMake build system in #15 .
I would like to point out that in your
CMakeLists.txt
you set the compilers name (nvc++
) as the CXX compiler, while this works well when cuDecomp is the top project, it fails for us when we add cuDecomp as subdirectory with this error"nvc++ " is not a full path and was not found in the PATH.
All you have to do is replace this code
With this one
I would be happy to make PR if you want.
Thank you.
The text was updated successfully, but these errors were encountered: