Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOTICE: Upcoming change to 3.x kernel argument ordering #890

Closed
mnicely opened this issue Mar 23, 2023 Discussed in #889 · 1 comment
Closed

NOTICE: Upcoming change to 3.x kernel argument ordering #890

mnicely opened this issue Mar 23, 2023 Discussed in #889 · 1 comment

Comments

@mnicely
Copy link
Collaborator

mnicely commented Mar 23, 2023

Discussed in #889

Originally posted by mnicely March 23, 2023
The CUTLASS 3.1 release will include a slight modification to the ordering of arguments passed in to 3.x kernels.
Existing CUTLASS 3.x kernel invocations will need to be modified to reflect this change.

The change involves moving the thread-level epilogue parameters to the beginning of the arguments list for the collective-level epilogue.

The change involves grouping parameters for operands A and B, and moving the thread-level epilogue parameters to the beginning of the arguments list for the collective-level epilogue.

The following diff illustrates an example of the changes that will be required in example 48:

-    block_A.get(),
-    stride_A,
-    block_B.get(),
-    stride_B,
-    {block_C.get(), stride_C, block_D.get(), stride_D, {options.alpha, options.beta}}
+    {block_A.get(), stride_A, block_B.get(), stride_B},
+    {{options.alpha, options.beta}, block_C.get(), stride_C, block_D.get(), stride_D}

Existing 3.x examples (48, 49, and 50) will be updated to reflect this change.

No CUTLASS 2.x kernels will be impacted by this change.

Please respond to this discussion if you have any questions about this upcoming change.

@mnicely mnicely pinned this issue Mar 23, 2023
@mnicely
Copy link
Collaborator Author

mnicely commented Apr 27, 2023

Released

@mnicely mnicely closed this as completed Apr 27, 2023
@mnicely mnicely unpinned this issue May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant