Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider not using a hyphen or dash in the tag #126

Open
debarshiray opened this issue Jun 24, 2024 · 0 comments
Open

Please consider not using a hyphen or dash in the tag #126

debarshiray opened this issue Jun 24, 2024 · 0 comments

Comments

@debarshiray
Copy link

Currently, the Git tags used in github.com/NVIDIA/go-nvml contain a hyphen or dash:

$ git tag
...
v0.12.3-0
v0.12.4-0

Some downstream distributors like Fedora package Go modules separately, and they don't expect the upstream version string to contain a hyphen or dash. Instead, they expect to use it to separate the upstream version number from the downstream build number.

So, if possible, it would be helpful if the hyphen or dash in the Git tags were replaced with a dot. eg., v0.12.3.0, v0.12.4.0, etc..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant