Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰[BUG]: dimensions in Chip 2D example #120

Open
shourya-p-otta opened this issue Mar 4, 2024 · 2 comments
Open

馃悰[BUG]: dimensions in Chip 2D example #120

shourya-p-otta opened this issue Mar 4, 2024 · 2 comments
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@shourya-p-otta
Copy link

Version

23.09,23.11, 24.01

On which installation method(s) does this occur?

No response

Describe the issue

nd_copper_source_grad = copper_heat_flux * length_scale / temp_scale is not non-dimensional.
Looks like final units are W/m^2/m-K = kg m^2 / s^3 /m^2 /m-K = kg / s^3 /m-K. This needs to be fixed.

nd_copper_source_grad = copper_heat_flux * length_scale / temp_scale

Minimum reproducible example

No response

Relevant log output

No response

Environment details

No response

Other/Misc.

No response

@shourya-p-otta shourya-p-otta added ? - Needs Triage Need team to review and classify bug Something isn't working labels Mar 4, 2024
@ktangsali
Copy link
Collaborator

@shourya-p-otta please refer this issue here: #109. This was a typo that was addressed recently

@shourya-p-otta
Copy link
Author

@ktangsali the results need to be updated as well in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants