Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰[BUG]: Corrdiff example script incorrectly assumes rectangular regions are patch based #522

Closed
daviddpruitt opened this issue May 23, 2024 · 0 comments
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@daviddpruitt
Copy link
Collaborator

Version

0.6.0

On which installation method(s) does this occur?

Docker, Pip, Source

Describe the issue

When giving a rectangular region for corrdiff training the script fails with the error "Rectangular patch not supported yet". This occurs even when not using patch based training. Its expected that rectangular regions are supported if they are the full domain.

Minimum reproducible example

No response

Relevant log output

Traceback (most recent call last):
  File "/root/modulus_corr_patch/examples/generative/corrdiff/train.py", line 351, in <module>
    main()
  File "/usr/local/lib/python3.10/dist-packages/hydra/main.py", line 94, in decorated_main
    _run_hydra(
  File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 394, in _run_hydra
    _run_app(
  File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 457, in _run_app
    run_and_report(
  File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 223, in run_and_report
    raise ex
  File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 220, in run_and_report
    return func()
  File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 458, in <lambda>
    lambda: hydra.run(
  File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/hydra.py", line 132, in run
    _ = ret.return_value
  File "/usr/local/lib/python3.10/dist-packages/hydra/core/utils.py", line 260, in return_value
    raise self._return_value
  File "/usr/local/lib/python3.10/dist-packages/hydra/core/utils.py", line 186, in run_job
    ret.return_value = task_function(task_cfg)
  File "/root/modulus_corr_patch/examples/generative/corrdiff/train.py", line 334, in main
    raise NotImplementedError("Rectangular patch not supported yet")
NotImplementedError: Rectangular patch not supported yet

Environment details

No response

@daviddpruitt daviddpruitt added bug Something isn't working ? - Needs Triage Need team to review and classify labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant