Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action to auto-update gh-pages after tagging [skip ci] #211

Closed
wants to merge 14 commits into from
Closed

Add github action to auto-update gh-pages after tagging [skip ci] #211

wants to merge 14 commits into from

Conversation

YanxuanLiu
Copy link
Collaborator

fix #208

added a github action to auto-update gh-pages after tagging

Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
@YanxuanLiu YanxuanLiu marked this pull request as ready for review April 7, 2023 01:46
@YanxuanLiu YanxuanLiu requested review from leewyang and pxLi April 7, 2023 01:46
@pxLi
Copy link
Collaborator

pxLi commented Apr 7, 2023

please also add test action run, example commit change refs/links to desc for review, thanks

cc @leewyang check if the workflow and actual doc content meet requirements, thanks

@pxLi pxLi changed the title Add github action to auto-update gh-pages after tagging Add github action to auto-update gh-pages after tagging [skip ci] Apr 7, 2023
@pxLi pxLi added the documentation Improvements or additions to documentation label Apr 7, 2023
@YanxuanLiu
Copy link
Collaborator Author

YanxuanLiu commented Apr 7, 2023

https://github.com/YanxuanLiu/spark-rapids-ml/actions/runs/4632181048
Success action run with tagging in fork repo

The commit made by the action:
YanxuanLiu@51182ee

@pxLi
Copy link
Collaborator

pxLi commented Apr 7, 2023

LGTM for CI part. Please help verify if any permission issue for automation account in this repo after merge (retag v22.02.0), thanks!

Waiting for developer to help check the content, thanks!

@leewyang
Copy link
Collaborator

leewyang commented Apr 7, 2023

I think we still need the cuml/rapids dependencies to be available/installed, e.g. like the CI/CD dockerfile. Otherwise, the API doc generation doesn't quite work, e.g.

Otherwise, the CI/automation part looks good to me.

@pxLi
Copy link
Collaborator

pxLi commented Apr 10, 2023

I think we still need the cuml/rapids dependencies to be available/installed, e.g. like the CI/CD dockerfile. Otherwise, the API doc generation doesn't quite work, e.g.

Otherwise, the CI/automation part looks good to me.

@YanxuanLiu then I think we could build and run https://github.com/NVIDIA/spark-rapids-ml/blob/branch-23.04/ci/Dockerfile in head of docs steps, could try follow https://stackoverflow.com/a/61155718.
Or we can try find some minimal requirements, and add the installation steps in https://github.com/NVIDIA/spark-rapids-ml/blob/branch-23.04/ci/docs.sh, the goal is to make sure the output doc is like expected one, thanks~

@leewyang
Copy link
Collaborator

leewyang commented Apr 10, 2023

FWIW, I think that the docs need to be built on a GPU host, because sphinx needs to be able to import the various packages to inspect them.

For example, I can successfully import cuml when using the CI docker image w/ --gpus 1, but if I run the same image without a GPU, the import fails with:

>>> import cuml
Traceback (most recent call last):
  File "/root/miniconda3/lib/python3.8/site-packages/cupy/__init__.py", line 18, in <module>
    from cupy import _core  # NOQA
  File "/root/miniconda3/lib/python3.8/site-packages/cupy/_core/__init__.py", line 3, in <module>
    from cupy._core import core  # NOQA
  File "cupy/_core/core.pyx", line 1, in init cupy._core.core
  File "/root/miniconda3/lib/python3.8/site-packages/cupy/cuda/__init__.py", line 8, in <module>
    from cupy.cuda import compiler  # NOQA
  File "/root/miniconda3/lib/python3.8/site-packages/cupy/cuda/compiler.py", line 14, in <module>
    from cupy.cuda import function
  File "cupy/cuda/function.pyx", line 1, in init cupy.cuda.function
  File "cupy/_core/_carray.pyx", line 1, in init cupy._core._carray
  File "cupy/_core/internal.pyx", line 1, in init cupy._core.internal
  File "cupy/cuda/memory.pyx", line 1, in init cupy.cuda.memory
ImportError: libcuda.so.1: cannot open shared object file: No such file or directory

So wondering if we can update gh-pages after a successful "build wheel and deploy" stage in Jenkins (on the same GPU build host)?

@YanxuanLiu
Copy link
Collaborator Author

Yes, we can run the auto-updating steps on a blossom host, so we can add the steps to release pipeline.

@YanxuanLiu YanxuanLiu closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CICD] Add github action to auto-update gh-page after tagging
3 participants