Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect Undeclared Shim in POM.xml #10166

Closed
razajafri opened this issue Jan 9, 2024 · 0 comments · Fixed by #10167
Closed

Detect Undeclared Shim in POM.xml #10166

razajafri opened this issue Jan 9, 2024 · 0 comments · Fixed by #10167
Assignees
@razajafri
Labels
bug Something isn't working

Comments

@razajafri
Copy link
Collaborator

Describe the bug
We ran into an issue where a shim was defined but not declared in the pom.xml. This causes the pre-merge to not pickup the new shim and potentially can break the build

Steps/Code to reproduce bug
Remove any version of a shim from pom.xml. e.g. Remove 334 from noSnapshot tag

Expected behavior
It should complain that a shim is defined but not declared in the pom

Additional context
#10163
@razajafri razajafri added bug Something isn't working ? - Needs Triage Need team to review and classify labels Jan 9, 2024
@razajafri razajafri self-assigned this Jan 9, 2024
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Jan 9, 2024
@razajafri razajafri mentioned this issue Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@razajafri razajafri

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Defined Shims Should Be Declared In POM razajafri/spark-rapids
2 participants
@mattahrens @razajafri