Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monitoring for GH action deprecations #10277

Closed
gerashegalov opened this issue Jan 26, 2024 · 5 comments
Closed

Add monitoring for GH action deprecations #10277

gerashegalov opened this issue Jan 26, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@gerashegalov
Copy link
Collaborator

I noticed by accident that there are numerous deprecation warnings on our GH workflows

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-java@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

On the one hand we need to fix them but we also could benefit from some automation surfacing these warnings

@gerashegalov gerashegalov added bug Something isn't working ? - Needs Triage Need team to review and classify labels Jan 26, 2024
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Jan 30, 2024
@YanxuanLiu
Copy link
Collaborator

I'll take care of this. Is it a good solution to run an action to check if there is deprecation for all actions used?

@gerashegalov
Copy link
Collaborator Author

Is it a good solution to run an action to check if there is deprecation for all actions used?

If you mean to check if any (one or more action) exhibit deprecation warnings I agree. You can research what is the best and/or easiest way forward for this:

  • whether it should be an non-blocking PR check
  • some alert sent to our gh status slack channel
  • some gh issue auto-creation with a uniq warning if there is no open yet with the same subject

@YanxuanLiu
Copy link
Collaborator

I'm trying to run a shell script with gh cli to scan all repos in NVIDIA group. This sh script may run on blossom.

@YanxuanLiu
Copy link
Collaborator

@gerashegalov I've added a blossom pipeline to scan all warnings of spark-rapids repos, and I've sent the review request to you. Could you help to review the MR? Thanks! Just slack me if you cannot find the MR.

@YanxuanLiu
Copy link
Collaborator

Fixed with a blossom pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants