Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] JsonScan and from_json share fallback checks, but have hard coded names in the results #10452

Closed
revans2 opened this issue Feb 21, 2024 · 0 comments · Fixed by #10490
Closed
Assignees
Labels
bug Something isn't working

Comments

@revans2
Copy link
Collaborator

revans2 commented Feb 21, 2024

Describe the bug
JsonScan and from_json share a lot of code, but the checks on the JsonOptions object that is shared does not distinguish between the two. So we get errors like.

Expression <JsonToStructs> from_json(StructField(str,StringType,true), (allowComments,true), value#43, Some(UTC)) cannot run on GPU because GpuJsonScan does not support allowComments

Where it is for JsonToStructs, but references GpuJsonScan. We should either remove all references to the name of the operation being done, or we need to pass it in as a parameter when doing the checks.

@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify labels Feb 21, 2024
@revans2 revans2 self-assigned this Feb 21, 2024
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants