Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Refine Spark UT Framework Part2: Use vectorized parameter to evaluate expressions where possible #10859

Closed
binmahone opened this issue May 22, 2024 · 2 comments
Closed

[FEA] Refine Spark UT Framework Part2: Use vectorized parameter to evaluate expressions where possible #10859

binmahone opened this issue May 22, 2024 · 2 comments
Assignees
@binmahone
Labels
test Only impacts tests

Comments

@binmahone
Copy link
Collaborator

binmahone commented May 22, 2024 •
edited
Loading

This is a follow up issue of #10850

In #10850 , we proposed a simple and quick solution to to meet code freeze deadline.

The solution still has room for improvement as stated in https://github.com/NVIDIA/spark-rapids/pull/10851/files/aa23967c3f1b04124f464489c0998ae60c377c50#diff-05efb25cde1790862698b49252ef40c62afb031d869bbb85e51e280192b2fc1fR225
@binmahone binmahone added feature request New feature or request ? - Needs Triage Need team to review and classify labels May 22, 2024
@binmahone binmahone self-assigned this May 22, 2024
@tgravescs
Copy link
Collaborator

tgravescs commented May 22, 2024 •
edited
Loading

Please change the description to be what this feature actually is then in description say its a followup from something.

@binmahone binmahone changed the title [FEA] Follow up issue of #10850 [FEA] Refine Spark UT Framework Part2: Use vectorized parameter to evaluate expressions where possible May 23, 2024
@binmahone binmahone mentioned this issue May 24, 2024
Merged
@binmahone
Copy link
Collaborator Author

close this issue as it is solved by #10861

@sameerz sameerz added test Only impacts tests and removed feature request New feature or request ? - Needs Triage Need team to review and classify labels May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@binmahone binmahone

Labels
test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tgravescs @binmahone @sameerz