You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure we need this at all. The foldable check was put in place a long time ago when each expression had to have explicit support for scalar values. We refectored the code a while ago and removed that. Just the fact that it works for testing means that the refactor was correct and I think we can just delete the check entirely.
To be clear in order to remove isFoldableNonLitAllowed. We need to remove the check for the foldable config entirely. We fixed the issue related to it a long time ago, but we never updated the code to ignore it. It would be good to disable folding for some of the integration tests, like some binary operations, and add in a few tests that would pass in all literal parameters to validate that those expressions are doing the right thing.
from Bobby:
Details explained at https://github.com/NVIDIA/spark-rapids/pull/10851/files/7237cb601ff9e8097deab6e95c968f6cb4c863a7#r1608257029
The text was updated successfully, but these errors were encountered: