Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Fall back to the CPU when LEAD/LAG wants to IGNORE NULLS #1923

Closed
nartal1 opened this issue Mar 12, 2021 · 1 comment · Fixed by #3387
Closed

[FEA] Fall back to the CPU when LEAD/LAG wants to IGNORE NULLS #1923

nartal1 opened this issue Mar 12, 2021 · 1 comment · Fixed by #3387
Assignees
@revans2
Labels
audit_3.2.0 feature request New feature or request P0 Must have for release
Projects
Release 21.10
Milestone
Aug 30 - Sept 10

Comments

@nartal1
Copy link
Collaborator

nartal1 commented Mar 12, 2021

Is your feature request related to a problem? Please describe.
Support [ IGNORE NULLS | RESPECT NULLS ] for LEAD/LAG was added here: apache/spark@3e9821edfd . Need to evaluate and add tests.
@nartal1 nartal1 added feature request New feature or request ? - Needs Triage Need team to review and classify audit_3.2.0 labels Mar 12, 2021
@sameerz sameerz added P0 Must have for release and removed ? - Needs Triage Need team to review and classify labels Apr 6, 2021
@sameerz
Copy link
Collaborator

sameerz commented Apr 6, 2021

@mythrocks this is a change in windows lead / lag for Spark 3.2. Minimally we need to not map to the GPU if we cannot support the new functionality.

Are any cudf changes required to support this?

@revans2 revans2 self-assigned this Sep 3, 2021
@revans2 revans2 changed the title [FEA] LEAD/LAG should support [ IGNORE NULLS | RESPECT NULLS ] [FEA] Fall back to the CPU when LEAD/LAG wants to IGNORE NULLS Sep 3, 2021
@revans2 revans2 mentioned this issue Sep 3, 2021
Merged
@revans2 revans2 added this to To do in Release 21.10 via automation Sep 3, 2021
@revans2 revans2 added this to the Aug 30 - Sept 10 milestone Sep 3, 2021
Release 21.10 automation moved this from To do to Done Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@revans2 revans2

Labels
audit_3.2.0 feature request New feature or request P0 Must have for release
Projects
No open projects
Release 21.10
Done
Milestone
Aug 30 - Sept 10
Development

Successfully merging a pull request may close this issue.

Fallback to the CPU for IGNORE NULLS on lead and lag revans2/spark-rapids
3 participants
@revans2 @sameerz @nartal1