Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support FromUnixTime for non UTC timezones #6836

Closed
revans2 opened this issue Oct 18, 2022 · 0 comments · Fixed by #9814
Closed

[FEA] Support FromUnixTime for non UTC timezones #6836

revans2 opened this issue Oct 18, 2022 · 0 comments · Fixed by #9814
Assignees
Labels
feature request New feature or request

Comments

@revans2
Copy link
Collaborator

revans2 commented Oct 18, 2022

Is your feature request related to a problem? Please describe.
This is very similar to #6834 and does not depend on it, but does depend on #6831and #6832. But it probably would be good to have GpuHour working before we try to tackle this. The reason this one is on its own is because unix time stamps are in seconds where as a TimestampType is in microseconds. So the conversion to the desired time zone needs to be done in seconds. Ideally just like with GpuHour the existing CUDF code will work unchanged.

We also need to be very careful with our tests just like with GPU hour.

Note that with the new timezone support we need to be very careful that we test this for ambiguous times where we might need to do some normalization to get the same answer. These would include things like times during a daylight savings time transition where an overlap can occur and there is an hour when two different offsets could happen. We might need to not just do the conversion to microseconds, but we might also need to convert it to the desired time zone and then convert it back to UTC.

@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify labels Oct 18, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Oct 18, 2022
@NVnavkumar NVnavkumar linked a pull request Dec 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants