Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better to do some refactor for the Python UDF code #9938

Closed
firestarman opened this issue Dec 4, 2023 · 0 comments · Fixed by #9902
Closed

Better to do some refactor for the Python UDF code #9938

firestarman opened this issue Dec 4, 2023 · 0 comments · Fixed by #9902
Assignees
@firestarman
Labels
bug Something isn't working

Comments

@firestarman
Copy link
Collaborator

There are more and more shims for Python UDF code, leading to a lot of duplicate code. And some shim class names are confusable, e.g. GpuArrowPythonRunnerShims, GpuPythonArrowShims.
All of these makes maintainance not an easy job now, espcially if any change in cuDF API. So it would be good to have some refactor for it.
@firestarman firestarman added bug Something isn't working ? - Needs Triage Need team to review and classify labels Dec 4, 2023
@firestarman firestarman mentioned this issue Dec 4, 2023
Merged
@firestarman firestarman self-assigned this Dec 4, 2023
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@firestarman firestarman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Some refactor for the Python UDF code[databricks] firestarman/spark-rapids
2 participants
@mattahrens @firestarman