Unresolved external symbols

[casool]

I'm unable to build my project upon including this create device line in my code:

#include <nvrhi/vulkan.h>
...
nvrhi::vulkan::createDevice(deviceDesc);
...

1>main.cpp
1>nvrhi_vk.lib(vulkan-resource-bindings.obj) : error LNK2001: unresolved external symbol "class vk::DispatchLoaderDynamic vk::defaultDispatchLoaderDynamic" (?defaultDispatchLoaderDynamic@vk@@3VDispatchLoaderDynamic@1@A)
1>nvrhi_vk.lib(vulkan-commandlist.obj) : error LNK2001: unresolved external symbol "class vk::DispatchLoaderDynamic vk::defaultDispatchLoaderDynamic" (?defaultDispatchLoaderDynamic@vk@@3VDispatchLoaderDynamic@1@A)
1>nvrhi_vk.lib(vulkan-state-tracking.obj) : error LNK2001: unresolved external symbol "class vk::DispatchLoaderDynamic vk::defaultDispatchLoaderDynamic" (?defaultDispatchLoaderDynamic@vk@@3VDispatchLoaderDynamic@1@A)
1>nvrhi_vk.lib(vulkan-graphics.obj) : error LNK2001: unresolved external symbol "class vk::DispatchLoaderDynamic vk::defaultDispatchLoaderDynamic" (?defaultDispatchLoaderDynamic@vk@@3VDispatchLoaderDynamic@1@A)
1>nvrhi_vk.lib(vulkan-compute.obj) : error LNK2001: unresolved external symbol "class vk::DispatchLoaderDynamic vk::defaultDispatchLoaderDynamic" (?defaultDispatchLoaderDynamic@vk@@3VDispatchLoaderDynamic@1@A)
1>nvrhi_vk.lib(vulkan-meshlets.obj) : error LNK2001: unresolved external symbol "class vk::DispatchLoaderDynamic vk::defaultDispatchLoaderDynamic" (?defaultDispatchLoaderDynamic@vk@@3VDispatchLoaderDynamic@1@A)
1>nvrhi_vk.lib(vulkan-raytracing.obj) : error LNK2001: unresolved external symbol "class vk::DispatchLoaderDynamic vk::defaultDispatchLoaderDynamic" (?defaultDispatchLoaderDynamic@vk@@3VDispatchLoaderDynamic@1@A)
1>nvrhi_vk.lib(vulkan-staging-texture.obj) : error LNK2001: unresolved external symbol "class vk::DispatchLoaderDynamic vk::defaultDispatchLoaderDynamic" (?defaultDispatchLoaderDynamic@vk@@3VDispatchLoaderDynamic@1@A)
1>nvrhi_vk.lib(vulkan-buffer.obj) : error LNK2001: unresolved external symbol "class vk::DispatchLoaderDynamic vk::defaultDispatchLoaderDynamic" (?defaultDispatchLoaderDynamic@vk@@3VDispatchLoaderDynamic@1@A)
1>nvrhi_vk.lib(vulkan-shader.obj) : error LNK2001: unresolved external symbol "class vk::DispatchLoaderDynamic vk::defaultDispatchLoaderDynamic" (?defaultDispatchLoaderDynamic@vk@@3VDispatchLoaderDynamic@1@A)
1>nvrhi_vk.lib(vulkan-queries.obj) : error LNK2001: unresolved external symbol "class vk::DispatchLoaderDynamic vk::defaultDispatchLoaderDynamic" (?defaultDispatchLoaderDynamic@vk@@3VDispatchLoaderDynamic@1@A)
1>nvrhi_vk.lib(vulkan-device.obj) : error LNK2001: unresolved external symbol "class vk::DispatchLoaderDynamic vk::defaultDispatchLoaderDynamic" (?defaultDispatchLoaderDynamic@vk@@3VDispatchLoaderDynamic@1@A)
1>nvrhi_vk.lib(vulkan-queue.obj) : error LNK2001: unresolved external symbol "class vk::DispatchLoaderDynamic vk::defaultDispatchLoaderDynamic" (?defaultDispatchLoaderDynamic@vk@@3VDispatchLoaderDynamic@1@A)
1>nvrhi_vk.lib(vulkan-allocator.obj) : error LNK2001: unresolved external symbol "class vk::DispatchLoaderDynamic vk::defaultDispatchLoaderDynamic" (?defaultDispatchLoaderDynamic@vk@@3VDispatchLoaderDynamic@1@A)
1>nvrhi_vk.lib(vulkan-texture.obj) : error LNK2001: unresolved external symbol "class vk::DispatchLoaderDynamic vk::defaultDispatchLoaderDynamic" (?defaultDispatchLoaderDynamic@vk@@3VDispatchLoaderDynamic@1@A)

My top level CMakeLists:

...
# Dependencies
find_package(Vulkan REQUIRED)
add_subdirectory(Dependencies)

if (VULKAN_FOUND)
    include_directories(${Vulkan_INCLUDE_DIRS})
    target_link_libraries (${PROJECT_NAME} ${Vulkan_LIBRARIES} Dependencies)
endif (VULKAN_FOUND)
...

Dependencies/CMakeLists:

...
set(NVRHI_BUILD_SHARED OFF CACHE BOOL "" FORCE)

set(NVRHI_WITH_DX11 OFF CACHE BOOL "" FORCE)
set(NVRHI_WITH_DX12 OFF CACHE BOOL "" FORCE)
set(NVRHI_WITH_VULKAN ON CACHE BOOL "" FORCE)

add_subdirectory(nvrhi)
target_link_libraries(Dependencies INTERFACE nvrhi)
target_link_libraries(Dependencies INTERFACE nvrhi_vk)
...

[pmrochen]

You have to declare an instance of vk::DispatchLoaderDynamic somewhere in your .cpp file.

The simplest way is to use helper macro:

//...
VULKAN_HPP_DEFAULT_DISPATCH_LOADER_DYNAMIC_STORAGE;
//...

[casool]

You have to declare an instance of vk::DispatchLoaderDynamic somewhere in your .cpp file.

The simplest way is to use helper macro:

//...
VULKAN_HPP_DEFAULT_DISPATCH_LOADER_DYNAMIC_STORAGE;
//...

Does nvrhi require me to use the Vulkan C++ bindings? Also, isn't this only necessary if you're building a shared library? It seems nvrhi should automatically do it for you:

nvrhi/src/vulkan/vulkan-device.cpp

Line 30 in a2e059a

VULKAN_HPP_DEFAULT_DISPATCH_LOADER_DYNAMIC_STORAGE

[pmrochen]

Unfortunately, by defining:

nvrhi/src/vulkan/vulkan-backend.h

Line 32 in a2e059a

#define VULKAN_HPP_DISPATCH_LOADER_DYNAMIC 1

nvrhi forces you to use C++ dynamic dispatcher, regardless you're building a shared library or not. In reality, it's not always the case, and you should have the ability to enable/disable dynamic dispatcher independently of shared library setting. Also, you should have the ability to issue VULKAN_HPP_DEFAULT_DISPATCHER.init() in your code, your way. It looks like we need two new configuration macros to cope with this issue.

[apanteleev]

NVRHI will create its own dynamic dispatcher when it's built as a shared library / DLL.
I recently suggested adding an option to do the same when it's built as a static library, with some caveats; see #48

[casool]

Unfortunately, by defining:

nvrhi/src/vulkan/vulkan-backend.h

Line 32 in a2e059a

#define VULKAN_HPP_DISPATCH_LOADER_DYNAMIC 1

nvrhi forces you to use C++ dynamic dispatcher, regardless you're building a shared library or not. In reality, it's not always the case, and you should have the ability to enable/disable dynamic dispatcher independently of shared library setting. Also, you should have the ability to issue VULKAN_HPP_DEFAULT_DISPATCHER.init() in your code, your way. It looks like we need two new configuration macros to cope with this issue.

So is the solution to include the Vulkan hpp header in my project?

[apanteleev]

Include the vulkan.hpp header and define VULKAN_HPP_DEFAULT_DISPATCH_LOADER_DYNAMIC_STORAGE somewhere at global scope. See https://github.com/NVIDIAGameWorks/donut/blob/main/src/app/vulkan/DeviceManager_VK.cpp for an example.

[casool]

Thanks!