Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spawnParameterizedRandomTarget() #13

Closed
bboudaoud-nv opened this issue Jun 21, 2019 · 3 comments · Fixed by #163
Closed

spawnParameterizedRandomTarget() #13

bboudaoud-nv opened this issue Jun 21, 2019 · 3 comments · Fixed by #163
Assignees
Labels
defer Defer working on this for a future date/request question Further information is requested

Comments

@bboudaoud-nv
Copy link
Collaborator

The spawnParameterizedRandomTarget() method is implemented but not called in App.cpp. Should we be moving to use of this method or removing it? This is related to issue #11.

@bboudaoud-nv bboudaoud-nv added the question Further information is requested label Jun 21, 2019
@jspjutNV
Copy link
Contributor

As I said in #11 , this function currently doesn't work correctly, but I believe we'd still like to fix it some time. Let's keep this bug open with low priority since it's not blocking progress at the moment.

@jspjutNV
Copy link
Contributor

To clarify some more, the way this should work is that it should spawn a target with the provided parameters which includes pre-computing the motion path for the given target with the provided motion parameters. It should match the specifications detailed by the Target/trial configurations

@bboudaoud-nv bboudaoud-nv added the defer Defer working on this for a future date/request label Jul 31, 2019
@jspjutNV
Copy link
Contributor

Considering the massive changes that have been made to our target types and the way targets are spawned at the moment, I believe this issue should be closed as it's no longer really relevant.

I'm going to open a pull request that removes the commented out and unused target spawning functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defer Defer working on this for a future date/request question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants