Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

fix school enrollment values #160

Merged
merged 5 commits into from
May 10, 2023
Merged

fix school enrollment values #160

merged 5 commits into from
May 10, 2023

Conversation

damonmcc
Copy link
Member

@damonmcc damonmcc commented May 9, 2023 •
edited
Loading

resolved #159

changes

  • fix calculations of enrollment by properly handling "percentage" values in source data
    • e.g. "82%" is now "0.82"
  • format relevant sql file
  • add new columns requested by Capital Planning (pe_seats_avail, ie_seats_avail, psis_seats)
  • include more source data in final files

notes

@damonmcc
Copy link
Member Author

damonmcc commented May 10, 2023 •
edited
Loading

shared 2023-05-10 outputs with Capital Planning for review

@damonmcc damonmcc marked this pull request as ready for review May 10, 2023 15:19
@damonmcc damonmcc changed the title fix school enrolment values fix school enrollment values May 10, 2023
@fvankrieken
Copy link

All seems pretty straight forward. Unless there's something specific you'd like to flag, lgtm

@damonmcc damonmcc merged commit 39c6764 into main May 10, 2023
1 check passed
@damonmcc damonmcc deleted the dm-fix-school-buildings branch May 10, 2023 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fvankrieken fvankrieken fvankrieken approved these changes

@mbh329 mbh329 Awaiting requested review from mbh329

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix school enrollment data
2 participants
@damonmcc @fvankrieken