-
Notifications
You must be signed in to change notification settings - Fork 2
/
CRDAO Feedback and responses
51 lines (25 loc) · 1.88 KB
/
CRDAO Feedback and responses
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
Direct failure response received from CRDAO, details:
My recommendation for 58
1:2 - PRIVACY MAPPING APPLICATION: Direct Fail
- No build or test running instructions on the README (added on main repo Read Me)
https://github.com/NYCyberLawyer/PRIVACYMAP/blob/main/README.md
- No usage documentation (added on main repo Read Me)
https://github.com/NYCyberLawyer/PRIVACYMAP/blob/main/README.md
- No description (expanded on the readme file and licensing)
https://github.com/NYCyberLawyer/PRIVACYMAP/blob/main/README.md
https://github.com/NYCyberLawyer/PRIVACYMAP/blob/main/LICENSE
- High-severity security vulnerabilities in their dependencies (Ran CodeQL and verified all vulnerabilities and dependencies)
Also Code scanning active and automated to run.
- Repo looks like folders pasted together for submission, rather than a coherent/living project
This was a migration from one of developers and it was verified and fixed upon feedback and gudelines from grant DXD #158
- No CI or static analysis (One folder has some GH actions but inactive because it is just a pasted folder)
Remediated the old file on GH actions and Code scanning active and automated to run.
- No proper API docs other than the docx file uploaded to the repo, which is not ideally following the common practices (new API doc with examples and expected outcomes)
https://github.com/NYCyberLawyer/PRIVACYMAP/blob/main/api/README.md
- No contribution or security policy I highly suggest for the OP to examine the repositories of well-known open source projects on GitHub, and study the DxD grant #185.
Secuirty policy - https://github.com/NYCyberLawyer/PRIVACYMAP/security/policy
New documentation based on feedback - https://github.com/NYCyberLawyer/PRIVACYMAP/blob/main/README.md
Adding testing video:
https://screencast-o-matic.com/watch/crXncAVlxfu
Bug Fix 03/25/2022 video:
https://www.youtube.com/watch?v=e9EHTU4GL5s